Skip to content

fix: correct license metadata in pyproject.toml - #61

Open
mateuscmtropical wants to merge 3 commits into
Infisical:mainfrom
mateuscmtropical:fix/pyproject-license
Open

mateuscmtropical wants to merge 3 commits into
Infisical:mainfrom
mateuscmtropical:fix/pyproject-license

Conversation

@mateuscmtropical

@mateuscmtropical mateuscmtropical commented Sep 15, 2026 •

Copy link
Copy Markdown

Description

pyproject.toml declared license = "NoLicense", even though the repo ships a real LICENSE file (MIT). This whole file is unedited OpenAPI Generator boilerplate (repository = "https://github.com/GIT_USER_ID/GIT_REPO_ID" and the generic authors field make that clear), so NoLicense looks like a leftover template default rather than an intentional choice.

setup.py, which is what publish-to-pip.yaml actually builds and publishes with (python setup.py sdist bdist_wheel), had no license metadata at all, so the published distribution's metadata was wrong too.

Fixes #57.

Change

  • pyproject.toml: license = "MIT" to match the repo's actual LICENSE.
  • setup.py: added license="MIT" so the metadata that actually ships to PyPI is correct.
  • setup.py: added classifiers=["License :: OSI Approved :: MIT License"]. The free-text license field alone doesn't drive PyPI's license badge/filter; the trove classifier is what PyPI and dependency scanners actually key off.

Type

  • Bug fix
  • New feature
  • Breaking change
  • Documentation

@greptile-apps

greptile-apps Bot commented Sep 15, 2026 •

Copy link
Copy Markdown
Contributor

RetriggerConfidence Score: 4/5

The change is non-breaking and safe to merge, though it leaves the published distribution’s license metadata uncorrected.

Findings

  1. P2 Published Metadata Remains Unchanged ▶
Summary

This PR changes the alternate package metadata in pyproject.toml from NoLicense to MIT, matching the repository’s license file.

  • Corrects the license value in the Poetry-style metadata.
  • Does not update the setuptools metadata used by the current PyPI release workflow.

Reviews (1) · Last reviewed commit: "fix: correct license metadata in pyproje..."

Comment thread pyproject.toml Resolved
@mateuscmtropical

Copy link
Copy Markdown
Author

Hi @varonix0 @victorvhs017, could you take a look at this when you have a moment? Happy to adjust anything.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Missing license information in pyproject.toml

1 participant