Repository navigation
fix: correct license metadata in pyproject.toml - #61
Open
mateuscmtropical wants to merge 3 commits into
Open
mateuscmtropical wants to merge 3 commits into
mateuscmtropical wants to merge 3 commits into
Conversation
Contributor
|
Author
|
Hi @varonix0 @victorvhs017, could you take a look at this when you have a moment? Happy to adjust anything. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
pyproject.tomldeclaredlicense = "NoLicense", even though the repo ships a realLICENSEfile (MIT). This whole file is unedited OpenAPI Generator boilerplate (repository = "https://github.com/GIT_USER_ID/GIT_REPO_ID"and the genericauthorsfield make that clear), soNoLicenselooks like a leftover template default rather than an intentional choice.setup.py, which is whatpublish-to-pip.yamlactually builds and publishes with (python setup.py sdist bdist_wheel), had no license metadata at all, so the published distribution's metadata was wrong too.Fixes #57.
Change
pyproject.toml:license = "MIT"to match the repo's actualLICENSE.setup.py: addedlicense="MIT"so the metadata that actually ships to PyPI is correct.setup.py: addedclassifiers=["License :: OSI Approved :: MIT License"]. The free-textlicensefield alone doesn't drive PyPI's license badge/filter; the trove classifier is what PyPI and dependency scanners actually key off.Type