Repository navigation
perf(metax): vectorize contiguous embedding lookups - #997
Open
JoeZhang-0x000 wants to merge 1 commit into
Open
JoeZhang-0x000 wants to merge 1 commit into
JoeZhang-0x000 wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contiguous MetaX embedding lookups at hidden size 4096 currently traverse the shared generic copy path. Add a MetaX override that copies each selected row with a 256-thread block and aligned vector loads/stores. Other shapes, layouts, unaligned pointers and max_norm continue through the existing implementation; other CUDA backends are unchanged.
Add coverage for the fast path, padded vocabulary rows, strided indices/weights/output, int32/int64 indices and max_norm fallback.
Validation on MetaX C550, MACA 3.8.0.23, PyTorch 2.10.0+metax3.8.0.7:
NVIDIA hardware was not available for testing. The change is confined to the MetaX specialization.