Repository navigation
Conversation
- 避免普通任务创建依赖未迁移的可选追踪列 - 保留有效 carrier 和超限 tracestate 计数 - 在真实 SDK 提交边界验证请求字段并更新运行文档
Member
Author
|
Public handoff: the PR body records the problem, validation, and rollback evidence. Next, @xiaoland coordinates code review and behavioral acceptance, then records the merge decision. The assignee accepts coordination responsibility; this does not represent independent reviewer approval. The PR is included under Review / acceptance on the current collaboration board. Record any new CI failure or behavioral blocker here so the board status is not mistaken for merge readiness. |
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Intent
With telemetry disabled,
JobManager.createstill insertssubmission_traceparent: nullandsubmission_tracestate: null. A self-hosted database without these optional columns then rejects basic job creation withPGRST204, even though there is no trace context to persist.captureSubmissionnow returns an empty object without a valid traceparent. With context, the same INSERT still carries the actual traceparent; absent, empty, or over-512-byte UTF-8 tracestate is omitted, and the oversized-carrier metric remains. There is no schema probing, retry with stripped fields, or database migration. Traced submissions still require those columns.Primary scope:
core. Affected delivery: shared SDK submission payload and consuming applications.Existing evidence
The author recorded workspace lint, type checking, builds, and package contracts; isolated OpenTelemetry cases covering disabled/invalid context, valid carriers, empty and oversized tracestate, and the metric; 22 Web E2E cases; and a synthetic job accepted by the actual older self-hosted schema. Temporary Job, Job Type, and Peer rows were removed and read back as absent. No user Source collection or deployment migration was triggered.
Seven GitHub checks passed for head
fcdbfb6dce0b7b0f6022b891bb548014d930ffbdon October 12. Preview: https://preview-client-web-pr-129.inkcre-client-web.pages.dev . Those results establish the recorded head, not compatibility with today's main. A previously reported unrelated local skill-formatting residual was excluded from this PR.Next action
@xiaoland coordinates the next response. Current main still has the null-field behavior, so the fix remains relevant. Update this branch against current main and rerun the required checks before merge; it is currently behind the protected branch. Review the no-context payload and tracestate boundary, and record the acceptance conclusion publicly. This handoff does not constitute an approving review.
Risk and rollback
Only absent optional submission fields are omitted. Trace-bearing jobs do not gain full compatibility with old schemas. Roll back the application artifact to reverse the payload change; no data migration or rollback is needed. Parent PR: none. Child PRs: none.