Skip to content

fix(typedoc): Apply fix suggestion for generic base types. Remove duplicate members from base type. #213

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
skrustev wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix(typedoc): Apply fix suggestion for generic base types. Remove duplicate members from base type. #213

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions plugins/typedoc-plugin-react-components/src/main.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -210,6 +210,7 @@ function parseTypeProperties(type: ts.Type, context: Context) {
if (
memberName.toString().startsWith('_') ||
excludeProperties.includes(memberName) ||
(context.scope as DeclarationReflection).getChildByName?.(memberName) ||
!(
modifiers === ModifierFlags.None ||
modifiers === ModifierFlags.Public ||
Expand Down Expand Up @@ -249,10 +250,15 @@ function parseTypeProperties(type: ts.Type, context: Context) {
}

function resolveBaseTypeProps(type: ts.Type, context: Context) {
if (!type.isClassOrInterface()) return;
const target =
type.flags & ts.TypeFlags.Object &&
(type as ts.ObjectType).objectFlags & ts.ObjectFlags.Reference
? (type as ts.TypeReference).target
: type;
if (!target.isClassOrInterface()) return;

const baseTypes = context.checker
.getBaseTypes(type)
.getBaseTypes(target)
.flatMap((base) => (base.isUnionOrIntersection() ? base.types : base));
for (const baseType of baseTypes) {
parseTypeProperties(baseType, context);
Expand Down
Loading