Repository navigation
fix(grid): preselect custom conditions in Excel-style filtering (22.2.x) - #17788
Open
viktorkombov wants to merge 1 commit into
Open
viktorkombov wants to merge 1 commit into
viktorkombov wants to merge 1 commit into
Conversation
viktorkombov
added
🐛 bug
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The localized fix preserves built-in fallback behavior, includes targeted regression coverage, and has no identified blocking issues.
0 open findings
What changed in this PR
Backports #17786 to 22.2.x, fixing custom-condition preselection in Excel-style filtering for Grid, Tree Grid, and Hierarchical Grid.
Changes:
- Resolves conditions from column filters before falling back to built-in operands.
- Adds regressions for custom string and number conditions and built-in fallback.
- Documents the fix in the changelog.
| File | Description |
|---|---|
| projects/igniteui-angular/grids/grid/src/grid-filtering-ui.spec.ts | Adds three regression tests. |
| projects/igniteui-angular/grids/core/src/filtering/excel-style/excel-style-custom-dialog.component.ts | Prioritizes column-defined filtering conditions. |
| CHANGELOG.md | Records the filtering fix. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #17636
Description
Preselect custom conditions in the Excel-style filter dialog while preserving the built-in fallback.
Motivation / Context
Backport of #17786 to 22.2.x.
Type of Change (check all that apply):
Component(s) / Area(s) Affected:
Grid, Tree Grid and Hierarchical Grid — Excel-style filtering.
How Has This Been Tested?
144 ESF tests passed, including three regressions.
npm run lint:libpassed.Test Configuration:
Screenshots / Recordings
N/A
Checklist:
feature/README.MDupdates for the feature docsREADME.MDCHANGELOG.MDupdates for newly added functionalityng updatemigrations for the breaking changes (migrations guidelines)