Repository navigation
Fix named tensor inner products - #272
Merged
Merged
Conversation
Align tensor dimensions and use the storage inner product so mixed-orientation fermionic tensors agree with their norms.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #272 +/- ##
==========================================
- Coverage 82.49% 82.36% -0.14%
==========================================
Files 21 21
Lines 1474 1474
==========================================
- Hits 1216 1214 -2
- Misses 258 260 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Delegate dimension alignment to TensorAlgebra.dot.
mtfishman
changed the title
mtfishman
changed the title
mtfishman
marked this pull request as ready for review
October 8, 2026 20:10
mtfishman
enabled auto-merge (squash)
October 8, 2026 20:15
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Use labeled
TensorAlgebra.dotfor named tensor inner products so fermionic tensors agree with their norms.