fix(client): apply the mTLS alias for revocation under certificate client auth - #550
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
…ient auth MTLSEndpoints.ApplyForClientAuth moved Token and PAR to their RFC 8705 §5 mtls_endpoint_aliases, but not the revocation endpoint added in v0.47.0. A client that authenticates with its certificate (tls_client_auth, self_signed_tls_client_auth) authenticates at RevokeToken too, so it must reach the endpoint where the server asks for that certificate. A certificate-authenticated client with DPoP-bound tokens, which applies only ApplyForClientAuth, sent its revocation requests to the plain endpoint. ApplyForClientAuth now applies the Revocation alias as well. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The note said the package had no trust marks and no server-side federation endpoints, but it now has VerifyTrustMark, SelfIssuer and SubordinateIssuer. It now says what Resolve itself does: resolves a leaf entity, returning its declared Trust Marks unverified for VerifyTrustMark. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
osanderson
force-pushed
the
fix/mtls-alias-revocation
branch
from
October 4, 2026 12:29
1176d73 to
a368902
Compare
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
These are two small corrections found while writing the mTLS and OpenID Federation guides (#549).
1.
fix(client):ApplyForClientAuthnow applies the revocation alias.MTLSEndpoints.ApplyForClientAuthmoved Token and PAR to their RFC 8705 §5mtls_endpoint_aliases, but not the revocation endpoint added in v0.47.0.tls_client_auth,self_signed_tls_client_auth) authenticates atRevokeTokentoo. So with DPoP-bound tokens, where onlyApplyForClientAuthapplies, it sent revocation requests to the plain endpoint instead of the one where the server asks for its certificate.ApplyForSenderConstrainalready covered revocation. NowApplyForClientAuthdoes too, and the test covers it; a mutation check confirms the test fails without the fix.2.
docs(federation):Resolver.Resolve's scope note was stale.VerifyTrustMark,SelfIssuerandSubordinateIssuerall exist now.Resolveitself does.Verification
go vet, the full test suite and golangci-lint are clean.🤖 Generated with Claude Code