Skip to content

fix: block prototype pollution in merge-allof-schema-properties.js #857

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
anupamme wants to merge 1 commit into
base: main
Choose a base branch
from
+6 −1
Open

fix: block prototype pollution in merge-allof-schema-properties.js #857

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion packages/ruleset/src/utils/merge-allof-schema-properties.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,12 @@ function mergeAllOfSchemaProperties(schema) {
* @param {*} sourceValue a field from the merge source
* @returns the "merged" value
*/
function customizer(targetValue, sourceValue) {
function customizer(targetValue, sourceValue, key) {
// Prevent prototype pollution by refusing to merge dangerous keys.
if (key === '__proto__' || key === 'constructor' || key === 'prototype') {
return targetValue;
}

// Allow non-object fields from the merge source to be overwritten in the target.
if (!isObject(sourceValue)) {
return sourceValue;
Expand Down