UID2-7874: separate React build and runtime dependencies - #214
Merged
Merged
Conversation
There was a problem hiding this comment.
🟢 Approval recommended
Dependency metadata and container stages consistently preserve required runtime packages while excluding development tooling.
Pull request overview
Separates build-time and runtime dependencies for both React examples and produces smaller, non-root runtime containers.
Changes:
- Reclassifies build tooling under
devDependencies. - Introduces multi-stage Docker builds with production-only installs.
- Adds consistent Docker build-context exclusions.
File summaries
| File | Description |
|---|---|
web-integrations/javascript-sdk/react-client-side/package.json |
Separates runtime and build dependencies. |
web-integrations/javascript-sdk/react-client-side/package-lock.json |
Records updated dependency classifications. |
web-integrations/javascript-sdk/react-client-side/Dockerfile |
Adds builder/runtime stages and non-root execution. |
web-integrations/javascript-sdk/react-client-side/.dockerignore |
Excludes local and generated files. |
web-integrations/google-secure-signals/react-client-side/package.json |
Separates runtime and build dependencies. |
web-integrations/google-secure-signals/react-client-side/package-lock.json |
Records updated dependency classifications. |
web-integrations/google-secure-signals/react-client-side/Dockerfile |
Adds builder/runtime stages and non-root execution. |
web-integrations/google-secure-signals/react-client-side/.dockerignore |
Expands Docker exclusions. |
Review details
- Files reviewed: 6/8 changed files
- Comments generated: 0
- Review effort level: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
…eason: automated release] Automated release (PR #215).
mcollins-ttd
previously approved these changes
Sep 18, 2026
mcollins-ttd
approved these changes
Sep 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
react,react-dom, andexpress) independencies.react-scriptsanddotenv, todevDependenciesin both React examples.nodeuser..trivyignoreunchanged; removing the existing CVE suppressions is intentionally deferred to a follow-up.Dependency classification
Packages imported by deployed application source remain production dependencies. Development dependencies are limited to tooling used to build, test, or develop the application and are not required by the deployed server or browser application.
dotenvis only used to load the repository.envfile locally; deployed environments inject variables directly, and the guarded import allows the server to run without it.Lockfile/toolchain notes
yaml@2.9.1entry required for cleannpm ciwith npm 10.2.4. No other package versions, resolved URLs, or integrity hashes changed.Testing
npm ciandCI=true npm run buildpass for both React examples using Node 20.11.0 / npm 10.2.4.reactandreact-dombut excludedotenvand the build-onlyreact-scripts,bfj, andjsonpathpackages.jsonpathfinding by default;--include-dev-depsstill reports it as expected.Out of scope
The pinned Alpine 3.18 base image and bundled npm CLI may still report unrelated vulnerability findings. Updating those components and removing obsolete
.trivyignoreentries should be handled separately.Jira: UID2-7874