Repository navigation
sync: type CodeRabbit auto-approve author set - #500
Merged
Merged
Conversation
Signed-off-by: Patrick Linnane <patrick@linnane.io>
p-linnane
force-pushed
the
coderabbit-set-type
branch
from
October 16, 2026 04:40
f3ef6b9 to
b9b5cae
Compare
p-linnane
added this pull request to stack #501
October 16, 2026 04:48
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With no approved authors, the synced
.coderabbit.config.tsbuildsnew Set([]), which TypeScript infers asSet<never>, so CodeRabbit flagged itshaslookup in Homebrew/brew.sh#1385. Declaring it asSet<string>fixes strict type-checking. The next sync updates.coderabbit.config.tsin every repository that receives it. The spec now strips TypeScript types before evaluating the configuration and checks that the annotation stays.GPT-6 Astra wrote the fix and reproduced the error with
tsc --strictand@coderabbitai/config. Claude Opus 5.5 reviewed it, re-ran that check on the old and new templates with empty and populated author lists and ran the spec with the GitHub Actions environment.Summary by CodeRabbit