feat(clusters): drop the unwired card metadata row and head the Clusters and Organizations pages with a plain title - #1771
Merged
Conversation
…cluster card The organization response the list is built from carries no instances, so two of the three tiles could only ever show a dash. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> (cherry picked from commit 038425d)
…d a tagline Neither line told a returning reader anything, and together with the eyebrow they cost the first row of cards about 120px. One heading, same size as the other page heads. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> (cherry picked from commit 016924d)
…and sits on the page margin The hero box (gradient card, padding) inset the title; the plain header row aligns it with the left margin like the organizations page, and the Dashboard.css override that only neutralised that box goes with it. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> (cherry picked from commit a39db4c)
…matches Organizations Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> (cherry picked from commit 714b177)
…matching the clusters page Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> (cherry picked from commit e5b246f)
Contributor
There was a problem hiding this comment.
Code Review
This pull request simplifies the user interface by streamlining the headers on the Clusters and Organizations pages, removing the hero banners, sub-headings, and descriptions in favor of clean, direct titles. Additionally, it removes the Instances, Regions, and Harper version metadata fields from the ClusterCard component since the organization response does not provide instance data, preventing empty or placeholder values from being displayed. Corresponding updates have been made to the E2E tests, unit tests, CSS styles, and design documentation to reflect these changes. I have no feedback to provide as the changes are clean and consistent.
Coverage Report
File Coverage
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||
…e count or version The model keeps deriving both, so the row is cheap to restore once an endpoint reports instances. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
DavidCockerill
force-pushed
the
david/1770-cluster-card-page-heads
branch
from
September 30, 2026 18:35
22524e5 to
27078c7
Compare
DavidCockerill
marked this pull request as ready for review
September 30, 2026 18:51
dawsontoth
approved these changes
Sep 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cluster cards no longer show the Instances / Regions / Harper version row: the organization response the list is built from carries no instances, so the instance count and version cells could only ever show a dash. The Clusters and Organizations pages now open with one plain heading in the primary colour instead of a slogan-and-tagline hero box, so the first row of cards sits about 120px higher. These are the same commits already on
epic/pricing-updates, landed onstageahead of the epic.Closes #1770
Before and after
Dark mode, 1440px, mocked API (the anon e2e fixtures). Light captures were taken too and look the same apart from the palette.
For the human reviewer
regionsfor the filter. Cost of a "no": one extra commit here and a matching change on the epic.h1per page, no slogan or tagline. Cheap to reverse apart from the three e2e locators. The copy goes for three reasons:cherry-pick -xcopies of the epic commits, byte-identical, so the epic's next rebase ontostagedrops them by patch-id. Squashing would leave the epic five conflicting commits to resolve by hand. Cost of a "no": one squash commit here and a manual conflict pass on the epic later.clusterListModel.tsstill derivesinstanceCountandversionalthough nothing renders them. Removing them would touch a file the epic also changes and would turn restoring the row into a model change. Cost of a "no": two unrendered fields and their tests until the row returns.Changes
src/features/clusters/components/ClusterCard.tsx: theCardContentholding the three-celldlis removed; the header and the progress/actions block are unchanged.src/features/clusters/ClustersList.tsx: the hero box (gradient card, eyebrow, slogan, tagline) becomes a plainheaderwith oneh1reading Clusters in the primary colour, violet in dark mode, keeping the New Cluster button.src/features/organizations/index.tsx: the same treatment, anh1reading Organizations replaces the eyebrow, slogan and tagline block.src/features/layouts/Dashboard.css: the.studio-shell .cluster-overview-herooverride goes with the hero box it neutralised.src/features/clusters/DESIGN.md: the note no longer says the card shows instance count and version; it says the model derives them, that only those two cells were always a dash because the organization response does not currently expand instances, and that the Regions cell went with the row.Verification
pnpm exec tsc -b,pnpm lint,dprint check: clean.pnpm test:coverage: 381 files, 3522 tests passed, 11 skipped.ClusterCard.test.tsxno longer expects the region label or the two "Not reported" cells.pnpm build: built.clusters.anon.spec.ts,global-search.anon.spec.tsandorganizations.anon.spec.tsassert the new Clusters and Organizations headings; the clusters spec still exercises the region filter and card navigation. Three failures insign-in.anon.spec.tsandverifying.anon.spec.tsreproduce on a cleanorigin/stagecheckout:getByLabel('Email')also matches the TanStack Router devtools button labelled/_authLayout/verify-email, which only renders on thepnpm devserver withVITE_DISABLE_DEVTOOLSunset. Not caused by this branch.verify-pr; the trusted lane runs these specs against the deployed dev app after the merge tostage.Complexity: easy
Review-Coverage: authored=claude; ran=gemini,codex; adjudicated=domain; declined=cursor-grok,cursor-composer,cursor-kimi,cursor-muse; rounds=1; full=1 @ 27078c7
Human-Review-Need: 3 (decisions: drop-card-regions, keep-dead-model-fields, plain-page-headings) @ 22524e5