Repository navigation
Conversation
Subsurface layer thickness should be dz*dz_mult
- Set initial ice impedance values to 1.0 - solver_richards.c: ice_impedance in wrong arg position when calling NonlinSolverInvoke - parflow_proto.h: Make eCLM-related fields easier to track by moving arg position of ice_impedance right next to evap_trans
- Receive ECLM_EFFPOROSITY from eCLM; keep ParFlow's porosity at uncoupled grid points - Update the received porosity after each converged step, capped so saturation stays <= 1 and floored at 0.01 - Include in storage term with separate porosity at both time levels and a freeze term (ice_liq_delta) for the liquid eCLM phase change
- Receive PFL_ICE_IMPEDANCE next to PFL_EFFPOROSITY - Store ice impedance in ProblemData and use it as flow barriers in NlFunctionEval and RichardsJacobianEval under HAVE_ECLM; no solver signature changes - Add NetCDF.WriteIceImpedance output - Send h2osoi_liq with dz*dz_mult (no change for DZ = 1.0)
- Remove PFL_ICE_IMPEDANCE; derive icefrac = 1 - porosity_recv/static_porosity - Impedance 10^(-e_ice*icefrac) per cell face in x, y and z; multiplies the flow barriers - New key Solver.ECLM.IceImpedanceFactor (default 6.0 = eCLM e_ice, 0 = off); add IceImpedance (z-face) as possible output
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
FYI @s-poll : this PR is a dry-run of the potential merge of your developments to the upstream Parflow branch. I thought an internal review with @skollet would be good before proceeding with the upstream Parflow pull request. This preparatory PR is also a chance to do final cleanups.
Note that the target branch (
eclm-frozen-soil-coupling) is based from the 8-Oct-2026 tip of Parflowmaster. This is set up so that eithereclm-frozen-soil-couplingordev-frozen-soil-couplingcould be merged to Parflowmaster, depending on the how the fixes go in this preparatory PR.