Repository navigation
Conversation
kvrigor
requested review from
AGonzalezNicolas,
DCaviedesV,
jjokella,
kgoergen and
s-poll
October 6, 2026 07:45
Contributor
|
To me, the "legal content" of the license is not changed, so that should be fine. Others have to check that the citation style/authors etc is correct, but from my side this is good. |
jjokella
previously approved these changes
Oct 6, 2026
s-poll
reviewed
Oct 7, 2026
s-poll
left a comment
s-poll
left a comment
Member
There was a problem hiding this comment.
I believe that, from a legal point of view, the PR is a change to the licence. It is these legal subtleties that could prove problematic. IMO, it might important here not to change the licence of CLM (CTSM). It might be possible to introduce a separate licence by using two licences, as it is also used at different repos. As having only a superficial understanding of licences can be dangerous, I would suggest that we ask the legal department to clarify this. There is certainly somebody at JSC/FZJ.
AGonzalezNicolas
previously approved these changes
Oct 8, 2026
Actual LICENSE is "University of Illinois/NCSA Open Source License" https://en.wikipedia.org/wiki/University_of_Illinois/NCSA_Open_Source_License
kvrigor
dismissed stale reviews from AGonzalezNicolas and jjokella
via
October 13, 2026 11:12
b31ecd2
kvrigor
changed the title
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CurrentCorrect LICENSE is University of Illinois/NCSA Open Source License (credits to @s-poll for the very important correction!)LICENSEfile is based from GitHub's BSD-3 license template. It would be better to use aLICENSEtext from a more authoritative source: https://opensource.org/license/BSD-3-Clause. Other references:This PR also fixes #134.