Repository navigation
fix: preserve runtime status, verification, and response identities - #270
dajiaohuang wants to merge 4 commits into
Conversation
|
Thank you for this, and welcome! We went through the three fixes one by one on main:
What we'd merge: keep the Windows |
|
Thanks for the detailed review. I addressed the remaining feedback in commit 2ff01d8 on this PR. Responses parsing now omits synthetic fc_0 IDs in non-stream, SSE, and SDK-stream paths when an item ID is absent; the converter supplies unique per-message/per-tool IDs. Added offline regressions for all three parser paths and a two-call roundtrip. Verification now disables only bare python/python3 remapping to DeepCode's interpreter; Windows .cmd/.bat wrapping remains. Replaced the active-interpreter assertion with a PATH-owned project-python regression; the npm launcher test remains. Validation: 28 focused tests passed, Ruff format/check passed on the seven changed files, and git diff --check passed. No live providers were used. GitHub currently reports no status checks for this head; the PR remains mergeable. No CI or merge acceptance is claimed. |
Description
This PR submits three independently reproduced runtime fixes preserved on the existing fork branch.
Related Issues
No directly matching open issue or pull request was found in the scoped current-object reconciliation. This does not duplicate #252, whose dependency change is already equivalent to upstream commit 3d40e25.
Changes Made
Checklist
Additional Notes
Validation on the saved candidate: 92 focused Windows/Python 3.13 tests passed, including CLI/npm/SQLite fixtures and a local provider transport roundtrip; changed-file Ruff format/check and staged whitespace checks passed. Full suite, Linux matrix, package/build, frozen Desktop and live-provider acceptance were not run. No merge or CI acceptance is claimed.