Repository navigation
feat(security): name the permission-bypass preset dangerous_skip explicitly - #266
Closed
raymondginger2018-sudo wants to merge 1 commit into
Closed
raymondginger2018-sudo wants to merge 1 commit into
raymondginger2018-sudo wants to merge 1 commit into
Conversation
…icitly Borrowed from Claude Code --allow-dangerously-skip-permissions: the escape hatch that skips every permission check should be named dangerous, so both the operator and the audit log see the choice for what it is.
Collaborator
|
Thank you, @raymondginger2018-sudo. We're closing this one: as written, the new preset can't be saved, and it isn't the same as Full Access.
Full Access already asks every client for an explicit risk acknowledgement. If you think its name or warning should be clearer, please open an issue about the wording first; a rename would need a migration, the protocol schema, all three clients and tests in one change. Please also keep code comments in English. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Borrowed from Claude Code
--allow-dangerously-skip-permissions: an escape hatch that skips every permission check should be NAMED dangerous, not sit silently underfull_access. AddsExecutionAccessPreset.DANGEROUS_SKIPwith the same strength profile asFULL_ACCESS, so operators and audit logs can tell a deliberate "I know this is dangerous" choice apart from ordinary full access.Lineage
Part of the 2026-08-19 "Claude Code lessons" branch. The sibling change (instruction-file glob excludes via
DEEPCODE_INSTRUCTION_EXCLUDES) already landed onmainin reworked form (core/harness/memory.pyowns it, with tests), so this PR carries only the still-missing preset.Verification
tests/domain/test_execution_security.py+tests/application/test_execution_security_policy.py+tests/contract/test_protocol_schema.py+tests/application/test_session_alignment.py+tests/application/test_turn_service.py= 71 passed.Checks
mainhas no "dangerous" preset (grep empty).StrEnumalready imported._PRESET_PROFILESentry; no default behavior change (no existing client passes the new value; the protocol-schema contract test passes unchanged).