Conversation
Assisted-by: OpenAI Codex
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Csvnormally passes an iterator of cast values topost_process, but itsNonebranch calls the same function without an argument. As a result,Csv(cast=int, post_process=sum)(None)raisesTypeErrorwhile the equivalent empty-string input returns0. A custom post-processor with a required argument also fails when used withConfig(..., default=None).Normalize
Noneto an empty string and reuse the existing parsing path. This supplies an empty iterator to the post-processor without calling the item cast, and preserves the empty list/tuple results.The regressions cover
Noneand empty-string input withlist,tuple,sum, andsorted, plus a custom iterator-consuming post-processor throughConfig(default=None). Before the fix, three regressions failed and nine CSV tests passed.Validation:
mock_openencoding tests failed identically in an untouched baseline checkout.git diff --check: passed.twine check: passed, with the existing warning about missinglong_description_content_type.This issue was identified during source review. The implementation and tests were prepared with OpenAI Codex assistance.