Repository navigation
Conversation
This PR brings the contents of `https://github.com/spcl/dace/blob/main/ci/pyfv3_legacy_nested_sdfgs.py` from the DaCe CI "down" into gt4py. Under the "no-view SDFG" contract, SDFGs must be "no view" before calling either `simplify()` or `inline_sdfgs()`. Both functions expect new-style nested SDFGs. `convert_legacy_nested_sdfgs()` does the convertion automatically and skips SDFGs that are already conforming to the new rules. The extra script in the DaCe CI can be removed once all of the following conditions are met: - This PR is merged. - GT4Py has been updated to use DaCe 2.0 beta 1 PR: GridTools#2937 - Both changes made it to NDSL, - NDSL was released and that release was picked up by pyFV3
romanc
requested review from
FlorianDeconinck
and removed request for
FlorianDeconinck
October 27, 2026 15:53
romanc
marked this pull request as draft
October 27, 2026 15:56
Contributor
Author
|
nevermind, |
edopao
added a commit
that referenced
this pull request
Oct 27, 2026
Contributor
Author
|
Closing in favor of #2937, which now contains the changes from this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR brings the contents of dace's ci/pyfv3_legacy_nested_sdfgs.py from the DaCe CI "down" into gt4py.
Under the "no-view SDFG" contract, SDFGs must be "no view" before calling either
simplify()orinline_sdfgs(). Both functions expect new-style nested SDFGs.convert_legacy_nested_sdfgs()does the convertion automatically and skips SDFGs that are already conforming to the new rules.The extra script in the DaCe CI can be removed once all of the following conditions are met:
We should probably update
freeze_origin_domain_sdfg()to not rely onconvert_legacy_nested_sdfgs()in the long run. For now, this should do and is a lot nicer than DaCe's CI injecting the extra function call when needed.Requirements