fix(lobby): Make the lobby server thread-safe - #66
Open
tintinhamans wants to merge 12 commits into
Open
tintinhamans wants to merge 12 commits into
tintinhamans wants to merge 12 commits into
Conversation
tintinhamans
force-pushed
the
arctic/fix/lobby-concurrency
branch
from
September 27, 2026 04:20
122d05f to
c7c7d49
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Lobby state was changed from HTTP handlers, websocket handlers and timers without consistent locking. That allowed duplicate lobby IDs, slot corruption during host migration, and leaves that finished after the next create or join.
CloseOpenSlotsand kicks. The kick's removal runs after the gate is released.LeaveAnyLobbyis awaited on create, join and delete.slot_stateand lobby update fields are validated (400 on bad values).