fix(communicator): Decode UTF-8 display names across the online UI - #620
Open
tintinhamans wants to merge 2 commits into
Open
tintinhamans wants to merge 2 commits into
tintinhamans wants to merge 2 commits into
Conversation
tintinhamans
force-pushed
the
arctic/go/fix/communicator-unicode
branch
from
September 27, 2026 00:25
ce28051 to
f0e74f6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Names from the service are UTF-8, but the communicator and notification popups turned them into wide text one byte at a time, so non-ASCII names came out garbled. They're now decoded with
from_utf8everywhere a name is shown.from_utf8/to_utf8use the Win32 converters, so invalid input shows as�instead of throwing. The Block tab is renamed to Blocked.