Repository navigation
feat(lapis)!: rename public siloVersion field and silo health component to rhydb - #1913
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
fengelniederhammer
changed the title
fengelniederhammer
requested review from
fhennig
and
a balanced review from Copilot
and removed request for
Copilot
October 14, 2026 08:06
fengelniederhammer
added this pull request to stack #1915
October 14, 2026 08:47
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The targeted rename is consistently propagated through implementation, schemas, and automated tests.
0 open findings
What changed in this PR
Renames public SILO-facing version and health fields to RhyDB terminology across LAPIS.
Changes:
- Renames
siloVersiontorhydbVersion. - Renames the health component and details to
rhydb. - Updates error messages, OpenAPI schemas, and tests.
| File | Description |
|---|---|
lapis/src/test/kotlin/org/genspectrum/lapis/rhydb/RhyDbClientTest.kt |
Updates RhyDB client expectations. |
lapis/src/test/kotlin/org/genspectrum/lapis/controller/OAuthTest.kt |
Updates mocked info data. |
lapis/src/test/kotlin/org/genspectrum/lapis/controller/InfoControllerTest.kt |
Verifies the renamed response field. |
lapis/src/main/kotlin/org/genspectrum/lapis/scheduler/DataVersionCacheInvalidator.kt |
Propagates renamed version data. |
lapis/src/main/kotlin/org/genspectrum/lapis/rhydb/RhyDbClient.kt |
Renames fields, logs, and errors. |
lapis/src/main/kotlin/org/genspectrum/lapis/response/RhyDbResponse.kt |
Renames the internal info property. |
lapis/src/main/kotlin/org/genspectrum/lapis/response/LapisResponse.kt |
Renames the public response property. |
lapis/src/main/kotlin/org/genspectrum/lapis/response/LapisInfoFactory.kt |
Populates the renamed property. |
lapis/src/main/kotlin/org/genspectrum/lapis/openApi/Schemas.kt |
Updates schema descriptions. |
lapis/src/main/kotlin/org/genspectrum/lapis/openApi/OpenApiDocs.kt |
Renames the OpenAPI property. |
lapis/src/main/kotlin/org/genspectrum/lapis/health/RhyDbHealthIndicator.kt |
Renames the health component and details. |
lapis/src/main/kotlin/org/genspectrum/lapis/controller/InfoController.kt |
Returns the renamed version field. |
lapis-e2e/test/info.spec.ts |
Updates info endpoint coverage. |
lapis-e2e/test/health.spec.ts |
Updates health endpoint coverage. |
lapis-e2e/test/aminoAcidSequence.spec.ts |
Updates error-message expectations. |
lapis-e2e/package.json |
Updates package terminology. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
fhennig
approved these changes
Oct 14, 2026
fengelniederhammer
pushed a commit
that referenced
this pull request
Oct 15, 2026
🤖 I have created a release *beep* *boop* --- ## [0.9.0](v0.8.9...v0.9.0) (2026-10-14) ### ⚠ BREAKING CHANGES * **lapis:** The `/info` (and `/sample/info`) response field `siloVersion` is renamed to `rhydbVersion`. The `/actuator/health` component `silo` is renamed to `rhydb`, with detail keys `rhydbStatus` and `rhydbVersion`. * **lapis:** deployment args: `--silo.url` is renamed to `--rhydb.url`, and the database-config key `siloClientThreadCount` to `rhydbClientThreadCount`. ### Features * **lapis-docs:** delete config generator ([#1914](#1914)) ([012a8c7](012a8c7)) * **lapis:** rename config silo.url to rhydb.url and siloClientThreadCount to rhydbClientThreadCount ([#1906](#1906)) ([36226b5](36226b5)) * **lapis:** rename public siloVersion field and silo health component to rhydb ([#1913](#1913)) ([2b9b0eb](2b9b0eb)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #1818 (Rename SILO to RhyDB: code).
Renames the user-facing SILO references in the
/infoand/actuator/healthresponses to RhyDB:inforesponse fieldsiloVersion→rhydbVersion(also in OpenAPI schema)silo→rhydb, with detail keyssiloStatus/siloVersion→rhydbStatus/rhydbVersionError from SILO:→Error from RhyDB:)Unit and e2e tests are updated to match.
BREAKING CHANGE: The
/info(and/sample/info) response fieldsiloVersionis renamed torhydbVersion. The/actuator/healthcomponentsilois renamed torhydb, with detail keysrhydbStatusandrhydbVersion.PR Checklist
llms.txt.