fix: allow sponsor Java source without local key - #115
Merged
yxsj245 merged 1 commit intoOct 2, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This follow-up fixes a usability regression after #112: the Java sponsor/high-speed source should still be installable without a locally saved sponsor key when the artifact exists.
This matches the upstream sponsor-download comments from
server/src/utils/sponsorDownload.ts: missing/invalid sponsor key or unavailable session service should fall back to the ordinary download channel, not disable the source.Changes:
Validation
git diff --check upstream/main...HEADnpm test --prefix server -- --runTestsByPath src/__tests__/java-download-artifacts.test.ts src/__tests__/architecture-support.test.ts-> 2 suites / 16 tests passednpm run build --prefix servernpm run build --prefix client-> passed, with existing Vite dynamic-import/chunk-size warnings only