Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates
nltkin both vLLM environment pin files to clear the reported advisories.Evidence:
envs/vllm/0.15.1/requirements.txtandenvs/vllm/0.12.0/requirements.txtpinnednltk==3.9.4osv-scannerreported 62 advisories fornltk@3.9.4(including GHSA-x99w-6fgc-pmfw, GHSA-rhp5-r9x4-f5g2, PYSEC-2026-3736) before the update3.10.3Validation:
osv-scanner --lockfile envs/vllm/0.15.1/requirements.txtand--lockfile envs/vllm/0.12.0/requirements.txtno longer report those 62 advisories after the updatepython -c "import nltk"passes withnltk==3.10.3on Python 3.12uv run pytest tests/ -vcould not complete here: the editable install resolves a large CUDA/torch dependency set that does not finish in this environment. The two env files are reference pins for prebuilt vLLM images andnltkis not imported by the package code or its tests.Note:
osv-scannerstill reports one advisory fornltk@3.10.3: GHSA-8mgp-746c-j5xp. No fixed release exists yet (3.10.3 is the latest nltk release), so this patch takes the package to the newest available version.Scope: the two
envs/vllm/*/requirements.txtfiles only.