Repository navigation
[BUGFIX] Keep spotlight holes on sticky and fixed elements while scrolling - #159
Merged
Merged
Conversation
…lling Since the overlay is anchored to the document, nothing updated its holes while scrolling. Sticky and fixed elements move within the document when the page scrolls, so after scrolling the overlay covered them and they could not be clicked anymore, e.g. editable content in a sticky header. Scrolling recomputes the holes again, at most once per frame and without measuring the document. The holes of all other elements keep their document coordinates, so the overlay path stays unchanged for them.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Since the spotlight overlay is anchored to the document (#144), nothing updates its holes while scrolling. Sticky and fixed elements move within the document when the page scrolls, so after scrolling the overlay covers them and they cannot be clicked anymore, e.g. editable content in a sticky header. In 1.10.4, the holes followed the scrolling.
Implemented behavior
Tests
spotlight-overlay.test.js(browser):npm run test: 91 passing,npm run lintFollow-up