Repository navigation
[BUGFIX] Do not let untouched invalid values block saving or change on focus - #156
Merged
Kanti merged 2 commits intoNov 9, 2026
Merged
Conversation
Values that violate the TCA, e.g. after the TCA became stricter, marked their field invalid on page load. This blocked saving the whole page, including auto save and "save and close", although unchanged fields are not saved at all. Only changed invalid fields block saving now. Unchanged invalid fields still show their validation errors.
Leaving a field normalized its value with the TCA rules even if the editor typed nothing: eval trim, upper, nospace and similar rewrote the value, values longer than max were cut, and values shorter than min were emptied. The record then counted as changed and was saved. An untouched value is kept now. Changed values are normalized as before.
Kanti
force-pushed
the
bugfix/untouched-invalid-fields
branch
from
November 9, 2026 12:50
e95248a to
95339f7
Compare
Kanti
marked this pull request as ready for review
November 9, 2026 12:56
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The validation of
f:render.textworks again. Values that violate the TCA, e.g. because the TCA became stricter after they were saved or because they were imported, now cause two problems:trim,upper,nospaceand similar rewrite it,maxcuts it, and values shorter than a non-requiredminare emptied. The record then counts as changed and is saved.Implemented behavior
dataHandlerStore.invalidCountonly counts invalid fields with changed data, andfocusFirstInvalidField()focuses the first changed invalid field. Unchanged invalid fields still show their validation errors.Tests
data-handler-store.test.js: only invalid fields with changed data are counted.ve-editable-text.test.js(browser): untouched values stay unchanged after focus and blur (this test fails without the fix), and a changed value is still normalized.npm run test: 89 passing,npm run lint, grumphp on TYPO3 14Builds on the browser test setup from "[TASK] Test the validation parsing of ve-editable-text in a browser".