Repository navigation
[TASK] Test the validation parsing of ve-editable-text in a browser - #155
Merged
Merged
Conversation
ve-editable-text declares validation as an Object property, so Lit parses the attribute in attributeChangedCallback. Since 1.7.3, connectedCallback, which runs afterwards, assigned the raw attribute again and replaced the parsed object with a string. This silently disabled the required, min, max and eval validation of f:render.text. The new test renders the component in Chromium with Playwright and checks upgraded elements, elements inserted after the definition and elements created with createElement. The JavaScript test job installs Chromium for it.
Kanti
force-pushed
the
test/ve-editable-text-validation
branch
from
November 9, 2026 12:49
fd09035 to
f905f39
Compare
Kanti
marked this pull request as ready for review
November 9, 2026 12:56
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ve-editable-text declares validation as an Object property, so Lit parses the attribute in attributeChangedCallback. Since 1.7.3, connectedCallback, which runs afterwards, assigned the raw attribute again and replaced the parsed object with a string. This silently disabled the required, min, max and eval validation of f:render.text.
The new test renders the component in Chromium with Playwright and checks upgraded elements, elements inserted after the definition and elements created with createElement. The JavaScript test job installs Chromium for it.