Conversation
Continues @vbernier02's work from FossifyOrg#123 and addresses the leftover review items from that PR. Co-authored-by: vbernier02 <102244975+vbernier02@users.noreply.github.com>
Contributor
|
Fossify accepts code contributions only for open issues labeled |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of change(s)
What changed and why
This continues @vbernier02's idea and first implementation in #123 (
feat: read only mode, Fixes #69). He handed the work to @naveensingh when he got busy. This PR is a new branch from currentmainso we do not push to his fork. It is not a claim that the feature is original.is_read_onlyon the note (Room v5). Review on feat: read only mode #123 first asked for session-only; this keeps persistence so the mode survives restart, matching the [fr] read only #69 request to avoid accidental overwrites. Happy to switch if you still want session-only.keyListener = null(that caused the long-press NPE on feat: read only mode #123)Tests performed
compileFossReleaseKotlin/ KSP on currentmainCloses the following issue(s)
Checklist
CHANGELOG.md(if applicable).