Skip to content

fix(ci): call notify-ci-failure from the public ForestAdmin/.github repo - #397

Merged
PMerlet merged 2 commits into
mainfrom
fix/notify-ci-failure-public-reusable
Sep 29, 2026
Merged

fix(ci): call notify-ci-failure from the public ForestAdmin/.github repo#397
PMerlet merged 2 commits into
mainfrom
fix/notify-ci-failure-public-reusable

Conversation

@PMerlet

@PMerlet PMerlet commented Sep 29, 2026 •
edited by macroscopeapp Bot
Loading

Copy link
Copy Markdown
Member

Every run of notify-ci-failure has failed at startup (0s) since Oct 2025: this public repo called ForestAdmin/github-workflows, which is private, and GitHub forbids that. Now calls the reusable workflow from ForestAdmin/.github (public).

Merge after ForestAdmin/.github#1

馃 Generated with Claude Code

Note

Update notify-ci-failure workflow to call the public ForestAdmin/.github repo

  • Switches the notification job to the reusable workflow from the public ForestAdmin/.github repository
  • Passes the Slack channel ID and SLACK_BOT_TOKEN explicitly instead of inheriting all caller secrets
  • Adds a workflow-level read permission for repository contents
  • Behavioral Change: secrets no longer inherited via secrets: inherit; the Slack bot token is now the only secret exposed to the reusable workflow in notify-ci-failure.yml

Changes since #397 opened

  • Added workflow run context inputs to reusable workflow invocation [b25555e]

Macroscope summarized 3a1f589.

@PMerlet @claude
fix(ci): call notify-ci-failure from the public ForestAdmin/.github repo
3a1f589 
A public repo cannot call a reusable workflow hosted in a private one, so
every run of this workflow failed at startup since it was added.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
@qltysh

qltysh Bot commented Sep 29, 2026

Copy link
Copy Markdown

Qlty


Coverage Impact

This PR will not change total coverage.

馃殾 See full report on Qlty Cloud 禄

馃洘 Help

  • Diff Coverage: Coverage for added or modified lines of code (excludes deleted files). Learn more.

  • Total Coverage: Coverage for the whole repository, calculated as the sum of all File Coverage. Learn more.

  • File Coverage: Covered Lines divided by Covered Lines plus Missed Lines. (Excludes non-executable lines including blank lines and comments.)

    • Indirect Changes: Changes to File Coverage for files that were not modified in this PR. Learn more.

nbouliol
nbouliol previously approved these changes Sep 29, 2026
View reviewed changes
@PMerlet @claude
fix(ci): pass workflow_run fields as inputs to notify-ci-failure
b25555e 
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
nbouliol
nbouliol approved these changes Sep 29, 2026
View reviewed changes

@nbouliol nbouliol left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved after /validator run 397-20260929125814-nbouliol: nothing at or above should-fix posted, 0 suppressed.

@PMerlet
PMerlet merged commit 12a3155 into main Sep 29, 2026
33 checks passed
@PMerlet
PMerlet deleted the fix/notify-ci-failure-public-reusable branch September 29, 2026 13:56
forest-bot added a commit that referenced this pull request Sep 29, 2026
@forest-bot
chore(release): 1.44.3 [skip ci]
66c81f8 
## [1.44.3](v1.44.2...v1.44.3) (2026-09-29)

### Bug Fixes

* **ci:** call notify-ci-failure from the public ForestAdmin/.github repo ([#397](#397)) ([12a3155](12a3155))
@forest-bot

forest-bot commented Sep 29, 2026

Copy link
Copy Markdown
Member

馃帀 This PR is included in version 1.44.3 馃帀

The release is available on GitHub release

Your semantic-release bot 馃摝馃殌

@linear-code

linear-code Bot commented Sep 30, 2026

Copy link
Copy Markdown

PRD-1045

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nbouliol nbouliol nbouliol approved these changes

Assignees

No one assigned

Labels

released

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@PMerlet @forest-bot @nbouliol