Repository navigation
ci: write the dummy prices in UTC, so that the day before a clock change works - #2760
Open
charanteja25 wants to merge 3 commits into
Open
charanteja25 wants to merge 3 commits into
charanteja25 wants to merge 3 commits into
Conversation
…nge works The Docker build check wrote the prices for tomorrow as local times without an offset, and loaded them with --timezone Europe/Amsterdam. On the day before a clock change that fails. In October the hour from 02:00 happens twice, and the file has it once (AmbiguousTimeError). In March the hour at 02:00 does not exist (NonExistentTimeError). Write the 24 hourly rows as UTC times that start at midnight in Amsterdam, and load them with --timezone utc. On a normal day these are the same instants as before. On the two days of a clock change, the 24 rows are 24 different hours. Signed-off-by: charanteja25 <charanteja.teja25@gmail.com>
Documentation build overview
178 files changed ·
|
Signed-off-by: charanteja25 <charanteja.teja25@gmail.com>
charanteja25
marked this pull request as ready for review
October 24, 2026 05:45
Signed-off-by: Gunisetty Venkata Charan Teja <charanteja.teja25@gmail.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Part of #2761.
ci/generate-dummy-price.shnow writes the 24 hourly rows as UTC times that start at midnight in Amsterdam, instead of as local times without an offset. The prices and their order are the same.docker-build.ymlloads them with--timezone utc, instead of--timezone Europe/Amsterdam.documentation/changelog.rstOn a normal day the rows are the same instants as before (
22:00Zin summer and23:00Zin winter for the first row). So the "Add Process schedule" step, which asks for prices from${TOMORROW}T00:00:00+02:00, keeps its price window.Look & Feel
Before, on 24 October 2026 (tomorrow is the day the clocks go back), the step "Add beliefs" failed:
On 27 March 2027 it would fail with
NonExistentTimeError: 2027-03-28 02:00:00.How to test
The check
build-docker-image / Build Docker Imageof this PR runs on the day before a clock change, so it tests the fix on a real runner.I also tested it before pushing:
timely_beliefs.read_csvand the prices from the script, for 2026-10-25 and 2027-03-28. WithEurope/Amsterdamboth give the errors above. Withutcboth are read as 24 rows.Further Improvements
The same recipe is in
documentation/tut/scripts/run-tutorial-in-docker.sh(manual QA workflow) and indocumentation/tut/toy-example-setup.rst. I did not change them here.Related Items
Part of #2761.
Sign-off