Skip to content

Fix tracing of BLR requests #9206

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hvlad merged 1 commit into from
Oct 9, 2026
Merged

Fix tracing of BLR requests #9206

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/jrd/jrd.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2705,6 +2705,7 @@ JRequest* JAttachment::compileRequest(CheckStatusWrapper* user_status,
&attachment->att_schema_search_path, attachment->att_blr_request_schema_search_path);

stmt = CMP_compile(tdbb, blr, blr_length, false, 0, nullptr);
stmt->blr.assign(blr, blr_length);

@hvlad hvlad Oct 8, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why restore old inefficient way that keeps almost never used blr string ?

@aafemt aafemt Oct 8, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because at this point there is no way to predict if it will be used in execute. Of course, some memory could be saved if only compile was able to print the BLR, but by design execute should be able to do it as well...

@aafemt aafemt Oct 8, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Besides, in contrast to DSQL-generated BLR, GPRE-generated BLR used to be short.


const auto rootRequest = stmt->makeRootRequest(tdbb);
rootRequest->setAttachment(attachment);
Expand Down
Loading