Repository navigation
Conversation
![ferrfleet-interne[bot]](https://avatars.githubusercontent.com/in/5311663?s=60&v=4){kind=small}
There was a problem hiding this comment.
Nothing blocking. The namespaced Role matches what cmd/main.go does with --watch-namespace: the cache is restricted to that namespace and workload reads stay namespaced. The lease stays in the pod's namespace, which the split leader-election Role handles correctly. One nit inline about leader-election Events.
There was a problem hiding this comment.
4678c3f adds the events rule to the leader-election Role, which closes the one nit I raised. Nothing else changed, and nothing is blocking.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #216
With
watchNamespaceset, the chart now renders aRoleandRoleBindingin that namespace instead of theClusterRoleandClusterRoleBinding. When leader election is on and the watched namespace differs from the release namespace, a separate lease-onlyRoleandRoleBindingis rendered in the release namespace.Rules are shared between both modes through helpers. Cluster-wide installs render the same rules as before.
Checked with
helm lintandhelm templatefor cluster-wide, same-namespace, other-namespace andrbac.create=false. The chart has no test suite.