Repository navigation
Conversation
Signed-off-by: BryanFRD <bryanferrando59@gmail.com>
![ferrfleet-interne[bot]](https://avatars.githubusercontent.com/in/5311663?s=60&v=4){kind=small}
There was a problem hiding this comment.
Looks right. It follows the pattern of the other workflows: the reusable workflow is pinned by SHA and contents: read is the only permission. Running on pull_request rather than _target is the correct choice, because the job checks out PR commits. The single commit is signed off.
Nit: .github/workflows/dco.yml:5: edited only fires on title/body/base edits, which don't change the commits. It reruns the check for nothing, except when the base branch changes. Drop it unless that base-change case matters to you:
types: [opened, synchronize, reopened]
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the shared DCO check (
FerrLabs/.githubreusable-dco). Every commit of a PR needs aSigned-off-byline; fix withgit rebase --signoff origin/main. Renovate signs off through the shared preset.