Repository navigation
Conversation
There was a problem hiding this comment.
This is correct. encodeURIComponent leaves . and .. as they are, so the WHATWG URL parser would have collapsed /sites/acme/releases/../restore. Rejecting both before encoding closes that hole. A %2e%2e input can't slip through either, because the % is encoded to %25.
I searched the repo and every encodeURIComponent path builder under mcp/packages is converted, so none were missed. @ferrlabs/mcp-core has no equivalent helper, so putting it in api-base.ts makes sense. Nothing blocking.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Path ids and slugs went through
encodeURIComponent, which leaves.and..intact, sofetchcollapsed them (e.g.restore_releasewithrelease_id: ".."hit/sites/acme/restore).All path interpolation now goes through
pathSegment, which throws on.and..before any request is made. Tests cover the helper and two tools (id and site slug).Closes #21