Repository navigation
fix(action): pick baseline artifact from main and skip expired ones - #288
Merged
Merged
Conversation
![ferrfleet-interne[bot]](https://avatars.githubusercontent.com/in/5311663?s=60&v=4){kind=small}
There was a problem hiding this comment.
Looks correct. Skipping expired artifacts is the real fix: before, per_page=1 could return an expired artifact and the download failed. The branch and repo filters are defensive, since uploads are already gated on refs/heads/main. Inlining ${{ github.repository_id }} into the jq filter is safe because it is numeric.
Nit: the comment above "Find full baseline artifact" still says "the most recent one is always a main baseline". With the new filter that reasoning no longer drives the lookup, so reword it to say the filter selects the newest unexpired main artifact.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Baseline lookups now filter the artifacts list to non-expired artifacts from main runs of this repository, instead of taking the newest artifact with that name. Applies to criterion-baseline and hyperfine-baseline.
No tests: the lookup is inline in action.yml with no test seam.
Closes #285