Skip to content

Default-deny Electron permissions - #86

Merged
FernandoAbishai merged 1 commit into
mainfrom
hardening/session-permissions
Oct 14, 2026
Merged

FernandoAbishai merged 1 commit into
mainfrom
hardening/session-permissions

Conversation

@FernandoAbishai

Copy link
Copy Markdown
Owner

Summary

  • install complete Electron session permission handling with both check and request handlers
  • default-deny every browser permission except clipboard-sanitized-write
  • require the exact ScriptCut webContents, main frame, and trusted requesting document URL before granting clipboard write
  • add packaged renderer permission probes without mutating the user clipboard
  • add static regression coverage for foreign contents, subframes and mismatched requesting URLs

Validation

  • npm run smoke:renderer-policy
  • npm run lint
  • packaged renderer: clipboard-write=granted, geolocation=denied
  • packaged creator qualification and optional capabilities green
  • full npm run release:rc:arm64 -- --require-mps from commit e3ee2b5 passed all candidate gates
  • independent review found one requester-frame gap; it was fixed and re-reviewed PASS with no remaining MUST-FIX

No Developer ID signing or notarization is claimed; candidate remains ad-hoc.

Copilot AI balanced review requested due to automatic review settings October 14, 2026 05:31
@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, you can upgrade your account or add credits to your account and enable them for code reviews in your settings.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@FernandoAbishai
FernandoAbishai merged commit 12c6fe4 into main Oct 14, 2026
2 checks passed
@FernandoAbishai
FernandoAbishai deleted the hardening/session-permissions branch October 14, 2026 05:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants