Skip to content

Restrict external navigation origins - #85

Merged
FernandoAbishai merged 1 commit into
mainfrom
hardening/external-navigation-policy
Oct 14, 2026
Merged

FernandoAbishai merged 1 commit into
mainfrom
hardening/external-navigation-policy

Conversation

@FernandoAbishai

Copy link
Copy Markdown
Owner

Summary

  • keep ScriptCut navigation locked to its exact renderer document
  • continue denying all window.open requests
  • only delegate external URLs for the two product-used HTTPS origins: github.com and www.python.org
  • parse URLs canonically with URL.origin rather than prefix matching
  • expand renderer-policy smoke coverage for userinfo/subdomain/scheme/non-default-port tricks and explicit window-open deny

Validation

  • npm run smoke:renderer-policy
  • npm run lint
  • full npm run release:rc:arm64 -- --require-mps from the implementation commit passed renderer transport, creator qualification, MPS, signing-readiness, DMG and metadata gates
  • independent read-only review: PASS, no MUST-FIX

No Developer ID signing or notarization is claimed; release candidate remains ad-hoc.

Copilot AI balanced review requested due to automatic review settings October 14, 2026 05:22
@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, you can upgrade your account or add credits to your account and enable them for code reviews in your settings.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@FernandoAbishai
FernandoAbishai merged commit 7b866c6 into main Oct 14, 2026
2 checks passed
@FernandoAbishai
FernandoAbishai deleted the hardening/external-navigation-policy branch October 14, 2026 05:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants