Skip to content

Trim Electron locale resources - #84

Merged
FernandoAbishai merged 1 commit into
mainfrom
optimization/electron-languages
Oct 14, 2026
Merged

FernandoAbishai merged 1 commit into
mainfrom
optimization/electron-languages

Conversation

@FernandoAbishai

Copy link
Copy Markdown
Owner

Summary

  • keep only English and Spanish Electron/Chromium locale resources on macOS (en, en_GB, es, es_419)
  • add an exact packaged locale checker used by both ad-hoc candidate and future signed release paths
  • statically pin the locale allowlist and both release gates in the release workflow contract

Size

Compared with the validated PR #83 release candidate:

  • app: 844,664,204 -> 798,420,936 bytes (-46,243,268 / -5.475%)
  • DMG: 284,802,926 -> 273,245,955 bytes (-11,556,971 / -4.058%)

Validation

  • electron-builder 26.15.3 config inheritance verified for self-contained/candidate/signed paths
  • old all-locale candidate correctly fails the new checker
  • rebuilt package retains exactly en/en_GB/es/es_419 in both app and Electron Framework resource roots
  • packaged backend, renderer transport, creator qualification and MPS compatibility passed
  • npm run release:rc:arm64 -- --require-mps passed all candidate gates from commit 229e66f
  • independent read-only review: no MUST-FIX

No Developer ID signing or notarization is claimed; candidate remains ad-hoc.

Copilot AI balanced review requested due to automatic review settings October 14, 2026 05:15
@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, you can upgrade your account or add credits to your account and enable them for code reviews in your settings.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@FernandoAbishai
FernandoAbishai merged commit cf1a4cf into main Oct 14, 2026
2 checks passed
@FernandoAbishai
FernandoAbishai deleted the optimization/electron-languages branch October 14, 2026 05:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants