Repository navigation
Prepare signed macOS release path - #81
Merged
Merged
Conversation
Add a credentialed Developer ID/Hardened Runtime/notarization configuration and exact-artifact verification path without changing the existing ad-hoc public alpha workflow.\n\nThe signed path reruns packaged runtime/backend/renderer/transcription gates, verifies the trusted app inside the DMG, disables publishing, and fails before mutation when signing or notary credentials are unavailable.
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The repository exposed
release:trust:signed, but that check loaded the ad-hoc candidate config. There was no concrete Developer ID/Hardened Runtime/notarization packaging path, and no verifier that proved Apple trust on the exact signed app.Change
electron-builder.signed.cjsfor Developer ID distribution signing, Hardened Runtime, minimal Electron JIT entitlements, and electron-builder notarizationrelease:signed:arm64, which hard-fails on missing credentials before clearing/building anythinghdiutilVerification
plutil -lint: PASSgit diff --check: PASSrelease:signed:arm64: correctly FAILS before artifact mutation withDeveloper ID credentials configured: NoandNotary credentials configured: NoCurrent limitation
A real signed artifact cannot be produced on this machine because there is no valid Developer ID Application identity and no notarization credentials. This PR prepares and verifies the credentialed path; it does not claim that Apple signing/notarization has already succeeded.
The DMG container is integrity-checked but is not described as independently signed/notarized. The Apple trust claims apply to
ScriptCut.appinside it, matching electron-builder 26.15.3 behavior.