Repository navigation
Conversation
…ents A component declared through a type variable erases to its bound while the property carries the resolved type; accept an assignable type instead of requiring an exact match.
cowtowncoder
added
blackbird
Member
|
3.3 is the right branch -- excellent. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #378.
generateRecordrequired each property's resolved type to equal the record component type, which never holds for a component declared through a type variable (Terases to its bound). The generated code passes components to the erased canonical constructor, so an assignable type is enough.Test:
BBCodecGenericRecordTestchecks codegen engages forEnvelope<Payload>and a boundedBounded<Integer>, and values match vanilla, including an absentTcomponent, a container argument and the raw type.