Repository navigation
[OoT] Fix colBounds computation when there are no collision triangles - #755
Open
Dragorn421 wants to merge 1 commit into
Open
Dragorn421 wants to merge 1 commit into
Dragorn421 wants to merge 1 commit into
Conversation
Dragorn421
added
bug
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently when exporting a map without any collision triangle (eg you disable collision for its only mesh) fast64 errors with an unhelpful message "IndexError: list index out of range"
This is due to colBounds staying
[]rather than taking a default value (eg[[0,0,0], [0,0,0]]like in this PR) when there is no collision triI tested in game that a map with such bounds and 0 tris does load so it barely makes sense to allow it
Also fixed some wrong type hinting on colBounds