Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds SeekDB as a third rebuildable derived-index backend while preserving
LanceDB as the default and keeping Markdown as the source of truth.
new SeekDB adapter;
connections, with optional dependency extras and validated configuration;
and cosine HNSW vector columns/indexes;
writes, native pagination, BM25 search, vector search, and strict column/index
drift diagnostics;
driver calls finish, restore physical-session settings after reconnects, and
suppress raw driver exception chains in application logs;
cascade rebuild, configuration examples, architecture/storagedocs, changelog, unit/contract/integration/e2e fixtures, and both embedded and
latest remote SeekDB CI jobs.
Closes #448.
Area
Verification
and configuration tests.
A process-local
fcntlimport shim was used only to collect portable tests;actual
flockcalls still raise. Real-engine tests require Linux/macOS or a configured remote endpoint andwere not executed locally.
physical connection replacement, and caller-side exception-log privacy tests.
metadata without treating engine-generated backing indexes as schema drift.
NO_BACKSLASH_ESCAPESenabled and verifies text round trips after recovery.asset/file-size gates, deprecated-name/contributor-doc gates, datetime discipline,
and documentation checks.
fork CI run:
port contracts; 27 passed for the tiered API suites.
the connection replacement regression; 27 passed for tiered API suites.
integration suites passed.
references an unavailable
minio/minioimage; this run is not fully green.workflows require maintainer approval; pending approval is not a passing check.
Checklist
main..envfiles, dependency folders, or generated output.Notes for Reviewers
The adapter isolates the SQL-oriented
pyseekdb1.4.x client surface in oneconnection manager and pins the optional dependency below 1.5 so future client
surface changes cannot silently alter the contract. Schema drift is fail-fast
because every physical table is disposable and rebuilt from Markdown with
everos cascade rebuild.The default install and default
[index] backend = "lancedb"behavior areunchanged.
By submitting this pull request, I agree that my contribution is licensed under
the Apache License 2.0.