Repository navigation
Fix live smoke tests: web-reader assertion, drop Hacker News - #3
Merged
Merged
Conversation
example.com removed its <h1>Example Domain</h1>, so the heading text no longer appears in the extracted body. Check the page title instead and keep a body-text assertion so extraction is still covered. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The front page consistently times out waiting for story rows on GitHub-hosted runners, while the markup is unchanged when fetched elsewhere, so the check fails without signalling a recipe regression. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The scheduled Live recipe smoke tests (run 37308424749) failed on two tests, both caused by changes outside this repo (no web2api core commits since the last green run).
test_web_reader: example.com removed its<h1>Example Domain</h1>, so the heading only exists as<title>. Assert on the item title and keep a body-text check ("documentation examples") so extraction is still covered.test_hackernews_read: removed. The front page times out waiting fortr.athingon GitHub-hosted runners (reproduced on a re-run), while the markup is unchanged when fetched elsewhere, so the check fails without indicating a recipe regression. The recipe itself is unchanged; the README now notes the exclusion.Verification
ruff check testspasses.🤖 Generated with Claude Code