Repository navigation
Support configuration cache - #74
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Makes BukkitGradle compatible with the configuration cache and declares it on the Plugin Portal.
Changes
:parsePluginYamltask.It set conventions on the
bukkit.pluginmodel during execution, which fails with the configuration cache: the task gets a deserialized copy of the model, and changes never reach:mainResourceFactory.The source
plugin.ymlis now parsed while:mainResourceFactoryis configured, usingproviders.fileContents, so the configuration cache is invalidated when the file changes.The file is decoded as UTF-8 regardless of the default charset.
com.gradle.plugin-publish1.3.1 → 2.2.1 and declareconfigurationCache = true.--configuration-cache, with new tests for cache reuse and for regeneration after the sourceplugin.ymlchanges or is created.Verification
./gradlew checkpasses (64 tests)../gradlew publishPlugins --validate-onlypasses without the compatibility warning.plugin.yml:jarandrunServer --dry-runstore and reuse the configuration cache, and the jar contains the mergedplugin.yml.Checklist:
🤖 Generated with Claude Code