Repository navigation
Conversation
…aspect and aura icon
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds an Opacity slider to Forever Essentials > General > Active Stance, Form, Aspect & Aura. It fades the icon and its border together, from 5 to 100 (default 100).
Requested by a player on an OLED screen who fades everything else on screen to avoid burn-in and found no way to fade this icon. Visibility can only hide it, and Mouseover is not offered for this element.
The value is applied with
SetAlphaon the addon's own icon frame inStyle(), so it takes effect on every settings apply. The slider sits on the last row of the section, beside a blank slot, and is hidden while the feature is off like the rows above it.How was it tested?
upstream/main. Locale keys unchanged ("Opacity" is already a key).guardrails.pynot run locally: noluac5.1on this machine. No new main-chunk locals were added.Screenshots
Missing: no before/after captures yet.
Checklist
SetAlphaper settings applyHookScript/hooksecurefunconly, neverSetScripton Blizzard frames - the frame is the addon's own