Skip to content

feat(foreveressentials): Opacity slider for the active stance, form, aspect and aura icon - #3433

Open
dfrisone wants to merge 1 commit into
EllesmereGaming:mainfrom
dfrisone:feat/active-form-opacity
Open

dfrisone wants to merge 1 commit into
EllesmereGaming:mainfrom
dfrisone:feat/active-form-opacity

Conversation

@dfrisone

Copy link
Copy Markdown
Contributor

What does this PR do?

Adds an Opacity slider to Forever Essentials > General > Active Stance, Form, Aspect & Aura. It fades the icon and its border together, from 5 to 100 (default 100).

Requested by a player on an OLED screen who fades everything else on screen to avoid burn-in and found no way to fade this icon. Visibility can only hide it, and Mouseover is not offered for this element.

The value is applied with SetAlpha on the addon's own icon frame in Style(), so it takes effect on every settings apply. The slider sits on the last row of the section, beside a blank slot, and is hidden while the feature is off like the rows above it.

How was it tested?

  • Not tested in game yet.
  • Both changed files parse under Lua 5.1.
  • EUI style check clean against upstream/main. Locale keys unchanged ("Opacity" is already a key).
  • guardrails.py not run locally: no luac5.1 on this machine. No new main-chunk locals were added.

Screenshots

Missing: no before/after captures yet.

Checklist

  • New settings default OFF (no behavior change without opt-in) - default opacity is 100, so existing setups look the same until the slider is moved
  • Zero cost while disabled: no events registered, no polling, no hooks doing work, no tickers; nothing built beyond an inert event frame or combat queue - no new events or hooks; the alpha is set only when the frame is styled
  • Cheap while enabled: event-driven (no polling, no timer-based logic, no per-frame allocations) - one SetAlpha per settings apply
  • No writes onto Blizzard-owned frames (weak-table pattern used); HookScript/hooksecurefunc only, never SetScript on Blizzard frames - the frame is the addon's own
  • Tested in-game on live; no version gates or pre-Midnight APIs added - no version gates or new APIs; not yet tested in game

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant