Repository navigation
Add opt-in embedded Keyring support to Forever Bags - #3425
Almightree wants to merge 12 commits into
Conversation
This reverts commit 1ea3092.
|
@Almightree Wow thank you so much for this feature! I notice one thing though. It adds an annoying keyring slot to all the other bag views (like All Items, Onebag, Multibag). It's overkill because checking keys is something we do very rarely. I would recommend a "..." dot menu next to this feature, which defaults to: "Don't show in general bag sections". So that it's only accessible by clicking the Keyring in the left bar. Otherwise that clutter on the normal bag view will drive me insane. ;D |
|
I also noticed that EllesmereUI recently has added a keyring skin (in 9.8.7 on November 15). Which honestly makes me wish you had gone more in the direction of #2688 with a single button that just opens the keyring without cluttering regular bags (or the bag category sidebar) at all. A very simple implementation would be:
That's the appropriate amount of access to a feature that people check once per year. Having it in the UI: Good. Cluttering the bags with it: Why? Maybe someone wants it in the regular bags for some reason. So this PR is fine. But it doesn't solve the issue of getting access to keys without cluttering the UI with it. |



What does this PR do?
Adds a Show Keyring option, disabled by default, for WoW Forever. Players can view and interact with keys directly inside EUI Bags.
The existing Keyring popup option remains available independently.
Feature request: https://ellesmereui.com/features/397/add-keyring-to-eui-bags
How was it tested?
Automated and static checks
Local behavioral harnesses and tooling are excluded from this PR.
In-game testing
WoW Forever 1.30.1.70938, tested by myself and Mantis:
Midnight 12.1.5.70783: smoke-tested with no Lua errors observed.
Formal taint-log verification was not performed by the contributor.
Screenshots
Before
After
Checklist
Closes #2688