Repository navigation
Conversation
…not stack With New Items Only on, an item with max stack 1 was listed by item ID, so crafting a third Red Linen Bag next to two carried ones listed all three. Copies are now told apart by item GUID while the option is on: Recent Items lists only the copies picked up since the item was listed. Every view, and the Recent category's icon picker, asks one per-slot predicate, EUI_Bags.IsRecentEntry, and the list view filters before it merges. The carried GUIDs are taken at the snapshot and when the option is turned on. A pass reads GUIDs only for items whose count changed or whose known GUIDs are incomplete, so a pass without such an item reads none; at the mailbox and in a trade every item that does not stack is read, so a copy received as another leaves still counts as new. Unknown data (no GUID, max stack not cached) falls back to every copy, as before. With the option off nothing changes and no GUID is read. Toggling the option now refreshes the bags.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Follow-up to #3346. With New Items Only on, an item that does not stack was matched by item ID, so crafting a third Red Linen Bag next to two carried ones listed all three under Recent Items. Now only the new copy is listed.
EUI_Bags.SeedRecentCopies), so nothing you held before shows up as new.EUI_Bags.IsRecentEntry(data): grid, list and the icon picker of the Recent category in the sidebar. While a per-copy set exists, the list view builds Recent from the unmerged entries, so Merge Duplicates does not pull the older copies back in.How was it tested?
In game on WoW Forever 1.60.1.70938 with EllesmereUI 9.8.8: crafting a third Red Linen Bag next to two carried ones lists only the new bag.
Lua 5.1 stub tests cover the copy rules, count-neutral swaps at the mailbox and in a trade, seeding when the option is turned on, the fallback for incomplete data, the option-off case without GUID reads, and the list view against upstream. They are not part of this PR (test files stay out per CONTRIBUTING), but I can share them on request.
python3 .tools/guardrails.pypasses.Checklist