Skip to content

Nameplates: repaint the WoW Forever group tint when a member's PvP flag moves - #3397

Open
tekert wants to merge 1 commit into
EllesmereGaming:mainfrom
tekert:fix/forever-party-tint-pvp-repaint
Open

tekert wants to merge 1 commit into
EllesmereGaming:mainfrom
tekert:fix/forever-party-tint-pvp-repaint

Conversation

@tekert

@tekert tekert commented Nov 15, 2026 •

Copy link
Copy Markdown
Contributor

What does this PR do?

Follow-up to #3284. In the WoW Forever style with Class Colored Health Bar off, a party or raid member's bar takes the engine's selection tint, UnitSelectionColor(unit, true). That tint follows the member's PvP flag:

Member Tint
PvP off 0.667, 0.667, 1.0 (lighter blue)
PvP on 0.667, 1.0, 0.667 (lighter green)

The flag moves on its own on a PvP ruleset (zoning, leaving a sanctuary or an instance), without any roster change. The group watcher only repainted on GROUP_ROSTER_UPDATE, and only the bars whose membership changed. So a member whose flag moved while their plate was on screen kept the old tint until the plate respawned: green after the flag dropped, or blue after it rose.

While the tint can show, the watcher now also listens to UNIT_FACTION. When the unit it names has a tinted full plate, that plate is marked, and the same next-frame pass repaints it. Other units return right away. When the tint can't show, UNIT_FACTION is unregistered with the rest.

How was it tested?

WoW Forever client (build 1.60.1.70938), in parties on a PvP ruleset, with a temporary logging addon that recorded each friendly group plate's bar colour next to the engine's tint.

Before this change (about 4 hours):

  • every flag change arrives as UNIT_FACTION, for the partyN token and for the member's nameplateN token;
  • the engine tint changes in that same event, matching the table above;
  • the plate kept its old colour, because nothing repainted it.

With this change (about 11 hours, over 40 flag changes across 11 members):

  • 3 of the flag changes happened with the member's plate on screen (twice PvP on to off, once off to on). Each time the bar took the new tint in the same second, repainted by the watcher's next-frame pass. Membership didn't change, so only the new UNIT_FACTION mark could have triggered that repaint.
  • In the 421 samples of a shown group plate, the bar matched the engine tint except at the instant of an event, and the next sample matched in every case.
  • When a member joined with their plate on screen, the bar was repainted from the plain friendly colour to the group tint, as before.
  • Watching the plates over those hours, I saw neither problem: no member kept a stale PvP tint, and no member showed the plain friendly bar colour, which I had seen the week before.

python .tools/guardrails.py passes. Rebased on v9.8.8.

Checklist

  • New settings default OFF -- N/A, no new setting; the change only applies where the group tint already applies (WoW Forever style, Class Colored Health Bar off)
  • Zero cost while disabled: UNIT_FACTION is registered only while the tint can show, and unregistered with the rest otherwise
  • Cheap while enabled: event-driven; a table lookup per UNIT_FACTION, and the repaint rides the existing next-frame pass
  • No writes onto Blizzard-owned frames
  • Tested in-game on live; no version gates or pre-Midnight APIs added -- tested on the WoW Forever client only, where this code path runs; no version gates or new APIs added

🤖 Generated with Claude Code

…ag moves

The group tint is the engine's selection colour, which follows the member's
PvP flag (lighter blue off, lighter green on). The watcher only repainted on
GROUP_ROSTER_UPDATE, and only bars whose membership moved, so a flag that
changed with the plate on screen left the old tint until the plate respawned.
While the tint can show, UNIT_FACTION now marks the tinted plate it names and
the same next-frame pass repaints it.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@tekert
tekert force-pushed the fix/forever-party-tint-pvp-repaint branch from 2560131 to 0498fe4 Compare November 17, 2026 00:57
@tekert
tekert marked this pull request as ready for review November 17, 2026 01:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant