Repository navigation
Conversation
…ag moves The group tint is the engine's selection colour, which follows the member's PvP flag (lighter blue off, lighter green on). The watcher only repainted on GROUP_ROSTER_UPDATE, and only bars whose membership moved, so a flag that changed with the plate on screen left the old tint until the plate respawned. While the tint can show, UNIT_FACTION now marks the tinted plate it names and the same next-frame pass repaints it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
tekert
force-pushed
the
fix/forever-party-tint-pvp-repaint
branch
from
November 17, 2026 00:57
2560131 to
0498fe4
Compare
tekert
marked this pull request as ready for review
November 17, 2026 01:01
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Follow-up to #3284. In the WoW Forever style with Class Colored Health Bar off, a party or raid member's bar takes the engine's selection tint,
UnitSelectionColor(unit, true). That tint follows the member's PvP flag:0.667, 0.667, 1.0(lighter blue)0.667, 1.0, 0.667(lighter green)The flag moves on its own on a PvP ruleset (zoning, leaving a sanctuary or an instance), without any roster change. The group watcher only repainted on
GROUP_ROSTER_UPDATE, and only the bars whose membership changed. So a member whose flag moved while their plate was on screen kept the old tint until the plate respawned: green after the flag dropped, or blue after it rose.While the tint can show, the watcher now also listens to
UNIT_FACTION. When the unit it names has a tinted full plate, that plate is marked, and the same next-frame pass repaints it. Other units return right away. When the tint can't show,UNIT_FACTIONis unregistered with the rest.How was it tested?
WoW Forever client (build 1.60.1.70938), in parties on a PvP ruleset, with a temporary logging addon that recorded each friendly group plate's bar colour next to the engine's tint.
Before this change (about 4 hours):
UNIT_FACTION, for thepartyNtoken and for the member'snameplateNtoken;With this change (about 11 hours, over 40 flag changes across 11 members):
UNIT_FACTIONmark could have triggered that repaint.python .tools/guardrails.pypasses. Rebased on v9.8.8.Checklist
UNIT_FACTIONis registered only while the tint can show, and unregistered with the rest otherwiseUNIT_FACTION, and the repaint rides the existing next-frame pass🤖 Generated with Claude Code