Repository navigation
Share one set of operations between the main thread and the worker - #75
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Every read method on
NetCDF4was implemented twice: once for the main thread and once for the Web Worker used byfromBlobLazyandfromUrl. The two copies could drift apart, and the worker's copy was untested.All operations are now defined once, in the new
src/operations.ts. Both paths run the same code, and each public method is a single call.Because the tests run these operations on the main thread, they now also cover what the worker executes. Only the message passing and file mounting inside the worker still need a browser to test.
Small behavior changes
getDimIDs()andgetVarIDs()now return anInt32Array, as the main thread already did.TypeError.