Repository navigation
Add missing vegetation height - #105
Open
olivierbonte wants to merge 1 commit into
Open
olivierbonte wants to merge 1 commit into
olivierbonte wants to merge 1 commit into
Conversation
Contributor
Author
|
@bgctw does this fix seem correct to you? |
Member
|
Dear Oliver, yes. Thank you very much. I lookied into it and I am quite convinced that you fixed a bug. However,, I am waiting for the expert opinion of Jürgen Knauer, the author of the bigleaf R package, that has the same behaviour/bug. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Following equation 21 of Choudhury & Monteith 1988 (https://doi.org/10.1002/qj.49711448006), a vegetation height term was missing here