Repository navigation
Conversation
Signed-off-by: Kevin Wang <wy721@qq.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
RotateAcmeCredentialsto register Google Public CA accounts, without persisting the binding secret or changing existing{}requests.EAB registration is available through the authenticated admin RPC; the dashboard registration button remains EAB-free.
Validation
Linux x86_64, Rust/Cargo 1.92.0, default workspace features; local unit tests only, no TEE or GCP credentials. The ACME registration test uses a loopback mock server and synthetic HMAC keys.
cargo test --manifest-path dstack/Cargo.toml -p certbot --lib— 73 passedcargo test --manifest-path dstack/Cargo.toml -p dstack-gateway— 342 passedcargo check --locked --manifest-path dstack/Cargo.toml -p certbot -p dstack-gateway— passedcargo fmt --all --manifest-path dstack/Cargo.toml -- --checkandgit diff --check— passedReal Google Public CA staging issuance has not been exercised.