Conversation
- Replace the horizontal `Navbar` with a fixed `AppBar` + `SidebarNav` for primary navigation - Switch nav icons from `@mui/icons-material` to `lucide-react` - Add a Colours page mirroring Foundations/Theme Colours: Intent colours, Core brand colours (Brand/Tertiary/Highlight), and Neutral colours sections - Add an Elevation page: `Paper` swatches for elevation 0-24, a Layering section, a composed elevation + Danger container example, and a shadow-restoring components section - Add a Typography page listing every variant from `createDiamondTypography`
zoharma
force-pushed
the
zma/update-dev-app
branch
from
September 17, 2026 20:51
a8191a7 to
790672a
Compare
- material-react-table pulls its own nested @mui/material/@emotion, so DiamondDSTheme never reaches it (falls back to MUI's defaults) - extend dedupe beyond react/react-dom to cover those packages too
zoharma
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Navbarwith a fixedAppBar+SidebarNavfor primary navigation@mui/icons-materialtolucide-reactPaperswatches for elevation 0-24, a Layering section, a composed elevation + Danger container example, and a shadow-restoring components sectioncreateDiamondTypographydev/vite.config.tsso DiamondDSTheme actually reaches MRT (was silently falling back to MUI's stock theme, breaking dark mode)